Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix featured image placement #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix featured image placement #12

wants to merge 1 commit into from

Conversation

jeherve
Copy link

@jeherve jeherve commented Sep 16, 2011

Hi,

I have had to change entry-post.php to fix an issue nighthawk had with featured images. They appeared above the post title, instead of within the post (see image below).

So here is my commit, just in case!

Wrong image placement

Fixed

Place image below title to fix floating issue
@mfields
Copy link
Owner

mfields commented Sep 19, 2011

This is not actually a bug, but is how Nighthawk is intended to treat featured images. Both the image and the title should "align top" to one another. I can see what you are going for here and I think your design looks really great with the title underlined. I can see if I can work in a solution where the title is the first thing displayed as this is a much better thing to do. I should be able to float the title left and the image right so it behaves how I want it to while allowing it to do what you need at the same time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants