Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup only a subset of datasets, rather than entire pools #7

Closed
joelweinberger opened this issue Jul 11, 2012 · 3 comments
Closed

Comments

@joelweinberger
Copy link
Collaborator

I should be able to backup only a subset of my datasets. Namely, if I have the datasets:
fishtank/ubuntu-1
fishtank/ubuntu-2
I should be able to specify just to backi up fishtank/ubuntu-1 (and all of its dependent datasets, of course).

Where to put this on the destination pool is another question. For example, if I have the backup pool fishhatchery, and I want to only backup fishtank/ubuntu-1, should the resultant backup be fishhatchery/fishtank/ubuntu-1 or fishhatchery/ubuntu-1? Propbably the former as that would seem to have fewer conflicts in the long run.

@mfinifter
Copy link
Owner

Definitely the former. This is already what we are doing -- backups go to BACKUP_POOL_NAME/DATASET_NAME.

I agree that this is a useful feature. The question is opt-in vs. opt-out. I think in this case, I'm in favor of opt-out. Proposal: do not backup a dataset that has set the property "zfs-auto-backup:no-backup".

This actually makes me wonder if all config shouldn't occur as properties within the datasets. E.g.,

zfs set zfs-auto-backup:backup-pools=backup_ocean,backup_lake salmon_tank

This is opt-in, but it seems flexible enough to address both this issue and #6.

@joelweinberger
Copy link
Collaborator Author

I think this is a great point, and it's exactly correct. This should all be
properties on datasets. Good call.

On Wed, Jul 11, 2012 at 11:31 AM, Matthew Finifter <
reply@reply.github.com

wrote:

Definitely the former. This is already what we are doing -- backups go to
BACKUP_POOL_NAME/DATASET_NAME.

I agree that this is a useful feature. The question is opt-in vs.
opt-out. I think in this case, I'm in favor of opt-out. Proposal: do not
backup a dataset that has set the property "zfs-auto-backup:no-backup".

This actually makes me wonder if all config shouldn't occur as properties
within the datasets. E.g.,

zfs set zfs-auto-backup:backup-pools=backup_ocean,backup_lake salmon_tank

This is opt-in, but it seems flexible enough to address both this issue
and #6.


Reply to this email directly or view it on GitHub:
https://github.com/mfinifter/zfs-auto-backup/issues/7#issuecomment-6915291

@mfinifter
Copy link
Owner

Closing as a duplicate of #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants