Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bounding shape drawing #103

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

mfl28
Copy link
Owner

@mfl28 mfl28 commented Nov 10, 2023

  • Refactors bounding shape drawing using new BoundingShapeDrawer interface.
  • Adds listeners that trigger bounding shape drawing finalization whenever the user clicks outside of the imageview or requests the program to exit.
  • While drawing a polygon (after initial node click), all other existing bounding shapes in the scene are set to be mouse-transparent. This allows to draw polygons over other shapes. The mouse-transparency is reset when the drawn polygon is finalized.
  • As with the other shapes, when drawing a polygon (by clicking to add nodes) keyboard-shortcuts are now ignored until the polygon is finalized.
  • Updates and extends unit tests.

Closes #102 .

@mfl28 mfl28 self-assigned this Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (10520bc) 86.41% compared to head (72ffe78) 86.35%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     86.41%   86.35%   -0.06%     
- Complexity     1462     1477      +15     
============================================
  Files            92       95       +3     
  Lines          5880     5915      +35     
  Branches        538      529       -9     
============================================
+ Hits           5081     5108      +27     
  Misses          535      535              
- Partials        264      272       +8     
Files Coverage Δ
.../github/mfl28/boundingboxeditor/ui/EditorView.java 100.00% <ø> (ø)
.../mfl28/boundingboxeditor/ui/BoundingBoxDrawer.java 94.44% <94.44%> (ø)
...28/boundingboxeditor/ui/BoundingPolygonDrawer.java 93.54% <93.54%> (ø)
...ndingboxeditor/ui/BoundingFreeHandShapeDrawer.java 92.45% <92.45%> (ø)
...mfl28/boundingboxeditor/controller/Controller.java 78.82% <77.27%> (+0.40%) ⬆️
...fl28/boundingboxeditor/ui/EditorImagePaneView.java 82.45% <79.16%> (-6.92%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.2% 89.2% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit ea7d111 into master Nov 10, 2023
10 checks passed
@mfl28 mfl28 deleted the feature/refactor-bounding-shape-drawing branch November 10, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor bounding shape drawing
1 participant