Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null checks for textfield texts #110

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mfl28
Copy link
Owner

@mfl28 mfl28 commented Nov 15, 2023

  • Adds null-checks for textfield commit-events.

Fixes #109.

@mfl28 mfl28 self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (086724c) 86.53% compared to head (de38526) 86.46%.

Files Patch % Lines
...mfl28/boundingboxeditor/controller/Controller.java 44.44% 1 Missing and 4 partials ⚠️
...ngboxeditor/ui/settings/InferenceSettingsView.java 20.00% 0 Missing and 4 partials ⚠️
.../mfl28/boundingboxeditor/ui/TagScrollPaneView.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #110      +/-   ##
============================================
- Coverage     86.53%   86.46%   -0.08%     
  Complexity     1482     1482              
============================================
  Files            95       95              
  Lines          5928     5933       +5     
  Branches        531      534       +3     
============================================
  Hits           5130     5130              
  Misses          527      527              
- Partials        271      276       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.3% 72.3% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit 41df50f into master Nov 15, 2023
10 checks passed
@mfl28 mfl28 deleted the bugfix/fix-npes-on-textfield-commits branch November 15, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible NPEs on textfield commits
1 participant