Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shape group mouse-transparency when drawing #112

Merged

Conversation

mfl28
Copy link
Owner

@mfl28 mfl28 commented Nov 17, 2023

  • Sets bounding shape group mouse-transparent whenever shape drawing is initialized and resets it on drawing-finalization. This presents bounding shapes from intercepting mouse events while drawing is in progress.
  • Adds mouse-transparency checks to bounding shape drawing tests.

Fixes #111.

@mfl28 mfl28 self-assigned this Nov 17, 2023
@mfl28 mfl28 enabled auto-merge (squash) November 17, 2023 14:01
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41df50f) 86.46% compared to head (b076cca) 86.46%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #112   +/-   ##
=========================================
  Coverage     86.46%   86.46%           
+ Complexity     1482     1480    -2     
=========================================
  Files            95       95           
  Lines          5933     5933           
  Branches        534      534           
=========================================
  Hits           5130     5130           
  Misses          527      527           
  Partials        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfl28 mfl28 merged commit 3c086c9 into master Nov 17, 2023
10 checks passed
@mfl28 mfl28 deleted the bugfix/fix-shape-group-mouse-transparency-when-drawing branch November 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse-transparency is not set correctly when drawing bounding shapes
1 participant