Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Macos shortcut handling #95

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

mfl28
Copy link
Owner

@mfl28 mfl28 commented Oct 26, 2023

  • Uses platform specific shortcut (Ctrl on Windows/Linux, Cmnd on Macos) everywhere.
  • Updates unit tests to work on Macos.
  • Upgrades to latest JavaFX version which fixes some errors on MacOS (e.g. exception when dragging multiple files into the program).
  • Upgrades to latest testFX version.

Closes #94 .

@mfl28 mfl28 self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a08e876) 86.05% compared to head (931bffa) 86.30%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage     86.05%   86.30%   +0.24%     
- Complexity     1427     1437      +10     
============================================
  Files            92       92              
  Lines          5788     5789       +1     
  Branches        524      524              
============================================
+ Hits           4981     4996      +15     
+ Misses          546      538       -8     
+ Partials        261      255       -6     
Files Coverage Δ
.../mfl28/boundingboxeditor/ui/TagScrollPaneView.java 98.73% <100.00%> (ø)
...ndingboxeditor/ui/settings/SettingsDialogView.java 100.00% <100.00%> (ø)
...mfl28/boundingboxeditor/controller/Controller.java 78.96% <83.33%> (+0.63%) ⬆️
...fl28/boundingboxeditor/ui/BoundingPolygonView.java 85.48% <0.00%> (ø)
...fl28/boundingboxeditor/ui/EditorImagePaneView.java 88.97% <50.00%> (+2.36%) ⬆️
...ub/mfl28/boundingboxeditor/ui/BoundingBoxView.java 67.83% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.5% 86.5% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit 879866b into master Oct 27, 2023
10 checks passed
@mfl28 mfl28 deleted the feature/improve-macos-shortcut-handling branch October 27, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve macos shortcut handling
1 participant