isExteriorRing overflows stack on infinite loop in union

[terrencecrowley]

The function _calcEnclosingRing ends up returning the current ring. This causes isExteriorRing to recurse and stack overflow since it always defers to its enclosingRing (which is the same object in the case of this bug).

A simple patch to prevent this clear error by testing whether _calcEnclosingRing returns the current object and returning undefined in that case appears to fix the problem although I assume there is some deeper underlying issue that is not resolved by that fix and have not done enough testing to verify that that fix doesn't have other bad consequences.

Apologies I don't have a small repro case.

[pentacular]

Ah, I came to report this too.

Fortunately, I have a small reproducible case. :)

union([[[2, -2], [1, -1], [0, -2]]],
      [[[1, -1], [0, -1], [0, -2]]],
      [[[2, -2], [2,  0], [1, -1]]])

[mfogel]

awesome, thank you for the bug report. I've reproduced the issue on my side.

@pentacular - simple coordinates like that are like a dream. thank you!

[mfogel]

I just pushed a fix for this to master. The fix will be included in the next release to NPM, which I'm planning to push out in a week or two. Let me know if you run into any issues with the fix... cheers!

[terrencecrowley]

Much thanks for the quick response! I’ll validate when you push to npm. Terry From: Mike Fogel <notifications@github.com> Reply-To: mfogel/polygon-clipping <reply@reply.github.com> Date: Monday, February 18, 2019 at 10:41 AM To: mfogel/polygon-clipping <polygon-clipping@noreply.github.com> Cc: "tcrowley@alum.mit.edu" <tcrowley@alum.mit.edu>, Author <author@noreply.github.com> Subject: Re: [mfogel/polygon-clipping] isExteriorRing overflows stack on infinite loop in union (#69) I just pushed a fix for this to master. The fix will be included in the next release to NPM, which I'm planning to push out in a week or two. Let me know if you run into any issues with the fix... cheers! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#69 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AL05YdEdX6G8TRX36tXkTkXP7xifngpLks5vOvPkgaJpZM4a_57Q>.