Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as discussed in #28 , I made some changes to the setup.py file and installation instructions in the readme. I also uploaded to test-pypi and so everything seems to work as intended: https://test.pypi.org/project/pyphot/1.1/.
You can test it via
pip install -i https://test.pypi.org/simple/ pyphot==1.1 --no-deps
.If you give me the go-ahead, I'll push it to the proper PyPI Index. If you agree, can you give me your PyPI username so I can add you as an owner?
Once its on PyPI, I will also add it to conda-forge to deal with the annoying hdf5 binary dependency.