replace 'width: 100%' with 'marginHorizontal' to make style of line a…

…nd placeholder component more flexible.
mfrachet · Jun 10, 2019 · 657f686 · 657f686
1 parent c8275fe
commit 657f686
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/line/line.js b/src/line/line.js
@@ -4,7 +4,6 @@ import { View } from "react-native";
 export const Line = ({
   textSize = 12,
   color = "#efefef",
-  useDefaultWidth,
   style,
   noMargin = false,
   ...props
@@ -14,14 +13,13 @@ export const Line = ({
   const backgroundColor = color;
   const borderRadius = textSize / 4;
   const marginBottom = noMargin ? 0 : textSize;
-  const lineWidth = useDefaultWidth ? { width: "100%" } : {};
   const computedStyle = {
     height,
     alignSelf,
     backgroundColor,
     borderRadius,
     marginBottom,
-    ...lineWidth
+    marginHorizontal: 0
   };
 
   return <View style={[computedStyle, style]} {...props} />;

diff --git a/src/placeholder/placeholder.js b/src/placeholder/placeholder.js
@@ -5,7 +5,8 @@ import Animations from "../animation/animations";
 const styles = StyleSheet.create({
   container: {
     flexDirection: "row",
-    flex: 1
+    flex: 1,
+    marginHorizontal: 0
   },
   centerElement: {
     flex: 1
@@ -42,7 +43,6 @@ export const Placeholder = ({
   whenReadyRender: WhenReadyRender,
   renderLeft,
   renderRight,
-  useDefaultWidth = true,
   ...props
 }) => {
   const Root = customAnimation || makeRoot(animation);
@@ -53,10 +53,9 @@ export const Placeholder = ({
 
   const childrenArray = React.Children.toArray(children);
   const sizeOfChildren = childrenArray.length;
-  const containerWidth = useDefaultWidth ? { width: "100%" } : {};
   const userStyle = props.style;
   return (
-    <Root {...props} style={[styles.container, userStyle, containerWidth]}>
+    <Root {...props} style={[styles.container, userStyle]}>
       {renderLeft && withView(renderLeft, { style: styles.leftSide })}
       <View style={styles.centerElement}>
         {childrenArray.map((element, index) =>