Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest replacing 'width: 100%' with 'marginHorizontal' to make styles more flexible #81

Closed
runryan opened this issue Jun 10, 2019 · 1 comment
Closed

suggest replacing 'width: 100%' with 'marginHorizontal' to make styles more flexible #81

runryan opened this issue Jun 10, 2019 · 1 comment

Comments

@runryan
Copy link

runryan commented Jun 10, 2019

When I use Line and Placeholder components, I find it's hard to custom their width due to width: 100% limitation. Sometimes we just tell a component its marginHorizontal to calculate its width automatically. So I suggest replacing width: 100% with marginHorizontal:0 to make styles more flexible.
I've submitted a pull request. It failed anyway.
@mfrachet
Copy link
Owner

mfrachet commented Jul 9, 2019

Same as in the PR, thanks for the suggestion but I will probably keep the actual API 😊

@mfrachet mfrachet closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfrachet @runryan