replace 'width:100%' with 'marginHorizontal' #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its width automatically. So I suggest removing "width: 100%" property of line and placeholder. I give a useDefaultWidth property with default value 'true' instead. Now style of line and placeholder become more flexible.
…its width automatically. So I suggest removing "width: 100%" property of line and placeholder. I give a useDefaultWidth property with default value 'true' instead. Now style of line and placeholder become more flexible.
…nd placeholder component more flexible.
|
For a DX purpose, I'm not sure it's easier to rely on a marginRight things instead of the line of the component 🤔 Can you provide a snack reproduction of what gets you in trouble? Maybe we can adjust a bit and do it in another manner? 😊 |
|
I close this for now, feel free to answer. Thanks for the job by the way 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use Line and Placeholder components, I find they are hard to custom their width due to
width: 100%limitation. Sometimes we just tell a component its marginHorizontal to calculate its width automatically. So I suggest replacing 'width: 100%' with 'marginHorizontal' to make styles more flexible.