Babel for es2015 enviornments #69
Conversation
|
Travis seems to not be a big fan of yarn -- will investigate tomorrow. |
|
Travis has been fixed. The code coverage change comes because of the index file being changed. Would love some feedback :) |
.travis.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| language: node_js | |||
| node_js: | |||
| - "9" | |||
| - "stable" | |||
There was a problem hiding this comment.
Do you know why bumping to the last stable one would make this work?
There was a problem hiding this comment.
One of the modules in node_modules has a check to make sure the version of node being run is incompatible with node 9.
error sane@4.0.3: The engine "node" is incompatible with this module. Expected version "6.* || 8.* || >= 10.*".
I assume because this is they want you to be using a stable version, or one that is LTS. odd number releases are not LTS.
| presets.push(['@babel/preset-env', { modules: false }]); | ||
| } | ||
| return { presets }; | ||
| }; |
There was a problem hiding this comment.
What do you think of:
module.exports = api => {
const preset = api.env('test')
? 'module:metro-react-native-babel-preset'
: ['@babel/preset-env', { modules: false }];
return { presets: ['@babel/preset-react', preset]
};
Busy over here too. Will be using it in my fork in the meantime. Will switch to upstream when merged in. Cheers 🍻 |
|
Hi @rjerue ! I've released a v2.0.0 yesterday and wanted to know if you're still interested to work on this PR to integrate a build system to the lib? Thanks for your answer 😊 |
|
@mfrachet This is now done. Also have changed the code coverage to ignore the added "index" file and the "lib" ones. |
.gitignore
Outdated
| @@ -52,3 +52,5 @@ buck-out/ | |||
| fastlane/report.xml | |||
| fastlane/Preview.html | |||
| fastlane/screenshots | |||
|
|
|||
| lib | |||
There was a problem hiding this comment.
Well, I like to work and merge on master and to be able to test the bundles on this branch (or other branches) before publish on npm. So what do you think to leave the lib folder on the master branch?
I'm not sure it's a real problem. What do you think?
There was a problem hiding this comment.
It's not something I do as I don't like putting minified code onto git.
However, I think I've got a good idea for this. If we run the build as part of the precommit, that should rectify this as the latest build will always be in git.
As an added bonus, people can install from git as opposed to npm if they'd like.
| @@ -1,5 +1,5 @@ | |||
| language: node_js | |||
| node_js: | |||
| - "11" | |||
| - 'stable' | |||
| import replace from 'rollup-plugin-replace'; | ||
|
|
||
| const NODE_ENV = process.env.NODE_ENV || 'development'; | ||
| const outputFile = NODE_ENV === 'production' ? './lib/prod.js' : './lib/dev.js'; |
There was a problem hiding this comment.
I'm not sure to get why we need to rely on specific environements here? I'm not that good with building tools 😓
There was a problem hiding this comment.
Sometimes, bundled code works differently if built for dev or production. As a result, I actually compile two binaries. Prod.js and Dev.js. Often, prod dependencies log nothing related to debugging.
Your code isn't actually the reason that I'm doing this, it's because of the dependencies which in this case is only prop-types. I'm unsure if proptypes (or any of it's dependencies) require this. It's often best practice to just put it in something that in. The rollup config I use on my FOSS projects is pretty standard.
| @@ -31,9 +35,15 @@ | |||
| "dependencies": { | |||
| "prop-types": "15.6.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "^16.8.6" | |||
There was a problem hiding this comment.
Shouldn't we add react-native as a peer too?
There was a problem hiding this comment.
No, we don't add React-Native for the same reason we don't add react-dom.
React-Native-Web can be used instead, and npm will throw a warning every time an npm install is run.
|
I've took this open for too long. Thanks for the job you've made, I'm merging this and will check for further fix if I'm encountering problems 👌 |
Hello,
Love this library! I am using it in an environment where dependencies must be es2015 though and need it run through babel. Jest was already running things through babel.
This is a very normal thing for Javascript libraries. Especially those that can be leveraged on web and native.
yarn releasewill create the necessary files in a folder called 'lib' ... it's a prepublish hook so when you runyarn publishit should just work.Also upgraded Jest.
Tested on web and native, also passes jest tests.