Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set isInteraction: false to unlock runAfterInteractions() #82

Merged
merged 1 commit into from Jun 14, 2019

Conversation

usrbowe
Copy link
Contributor

@usrbowe usrbowe commented Jun 11, 2019

Motivation

In React Native, we can sometime use InteractionManger.runAfterInteractions() to postpone some heavy sync operations. For example fetching for data. When combining this approach with rn-placeholder, which would be showed as placeholder before fetching for data, this would prevent the dispatching the action.

Fix

Add isInteraction: false to Animated call. This will tell, that placeholder animation is not an interaction, thus InteractionManager, shouldn't be postponed until this one is finished (which in this case, will never happens as it is loop animation)

More info in RN docs: https://facebook.github.io/react-native/docs/animated#loop

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.821% when pulling e18f152 on smartkarma:master into 7bc174b on mfrachet:master.

@mfrachet
Copy link
Owner

Thanks for this 😊

@mfrachet mfrachet merged commit 1153075 into mfrachet:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants