Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add powered by button #365

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: add powered by button #365

merged 1 commit into from
Apr 5, 2024

Conversation

mfts
Copy link
Owner

@mfts mfts commented Apr 5, 2024

first step towards revamping the viewing mode

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 10:53am

Copy link

what-the-diff bot commented Apr 5, 2024

PR Summary

  • Introduction of PoweredBy Component
    A new file, namely components/view/powered-by.tsx, has been introduced. This contains a PoweredBy component, responsible for displaying a banner with a link to Papermark.

  • Component-level control for PoweredBy Banner Display
    The components components/view/PagesViewer.tsx, components/view/document-view.tsx, and components/view/view-data.tsx have been updated to include a property showPoweredByBanner. If this property is set to true, the PoweredBy banner is displayed.

  • Link Component Update in Navigation
    The href value for a Link component in components/view/nav.tsx has been updated with additional query parameters for improved URL structure and navigation function.

  • Addition of 'Team' Field in LinkWithDocument Interface
    The LinkWithDocument interface in lib/types.ts sees the addition of a new field team (optional). This team field comprises of a plan of type string to help categorize teams based on their plans.

  • Modification in API Response Structure
    The response structure in pages/api/links/[id]/index.ts has been tweaked to include a nested select field for team.plan.

  • Adjustments in ViewPage Component
    The ViewPage component, present in pages/view/[linkId]/index.tsx, has an additional property showPoweredByBanner which is extracted from the team.plan' field. This determines whether or not to display the PoweredBy` component.

@mfts mfts merged commit 64b8c23 into main Apr 5, 2024
2 checks passed
@mfts mfts deleted the feat/poweredby branch May 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant