Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #188 #189

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Resolves #188 #189

merged 2 commits into from
Jun 21, 2021

Conversation

mariohuq
Copy link
Contributor

After this change menu looks like

image

And settings open like this

image

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

Merging #189 (bcba191) into master (5563654) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files          15       15           
  Lines         638      638           
=======================================
  Hits          574      574           
  Misses         64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5563654...bcba191. Read the comment docs.

@mfuentesg
Copy link
Owner

@mariohuq could u tell me what is the behavior for sublime text v2? if everything works fine, we can merge it.

@mariohuq
Copy link
Contributor Author

@mariohuq could u tell me what is the behavior for sublime text v2? if everything works fine, we can merge it.

edit_settings doesn't work for Sublime Text 2, unfortunately.

@mfuentesg
Copy link
Owner

@mariohuq sync settings won't work on sublime text 2 anymore

@mfuentesg mfuentesg merged commit 41da8ea into mfuentesg:master Jun 21, 2021
Repository owner deleted a comment from allcontributors bot Jun 21, 2021
@mfuentesg
Copy link
Owner

@all-contributors please add @mariohuq as a contributor for code.

@allcontributors
Copy link
Contributor

@mfuentesg

I've put up a pull request to add @mariohuq! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants