Possibility of a timeout configuration

[ckipp01]

I noticed here, that there is a default of 2 seconds before a warning is shown to the user:

nvim-dap/lua/dap/session.lua

Line 816 in 208f174

timer:start(2 * sec_to_ms, 0, function()

I'm curious if you'd be open to having a different default being passed in for this, and if so what would you preference be on how to pass it in? When using nvim-metals I see this message quite a bit, so it'd be nice to be able to bump this a bit.

[mfussenegger]

Sounds good to me. Would you want to configure this as part of the adapter, or have it as user configuration?

I'm also fine with bumpin the built-in value a bit. But I wouldn't go too high as the "nothing happens" experience if something is not setup right (and the adapter doesn't return an error, but does just nothing) isn't ideal either. But 3 or even 4 seconds might still be okay?

[ckipp01]

Sounds good to me. Would you want to configure this as part of the adapter, or have it as user configuration?

Good question. At first my mind went towards being part of an adapter since it can be pretty language specific, but looking at what's available in the current adapter configurations, there really isn't other configuration settings like this there, so maybe it would be better as a user configuration. Did you have a suggestion or opinion on where this would fit better?

But 3 or even 4 seconds might still be okay?

Yea I think that should be good.

[ckipp01]

I wanted to revisit this if that's alright. I've been using this more lately on some projects that are larger than the ones I've tested with in the past. Almost every time I run a test I hit on this, and I've gotten feedback that other users in Scala have as well. I think just because of the nature of Scala and having to ensure everything is compiled first, then some extra stuff on the server side to grab the tests potentially in the file, and then finally return the results, the 4 seconds isn't enough.

Looking at it, what I was thinking would be nice was to be able to just update this in my enrich_config here:

https://github.com/scalameta/nvim-metals/blob/86dadf8c68b93037d7e1dc4b47f731e52bda0514/lua/metals/setup.lua#L146-L151

I could default it to a bit higher, and then a user could also add it to their config if they wanted to change it. Then this would just be passed in as part of the config to the initialize:

nvim-dap/lua/dap/session.lua

Line 817 in b17d513

function Session:initialize(config, adapter)

If present use it, or else default to the current. Does this sound alright to you? If so I'll shoot in a pr.