Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a widget api #171

Merged
merged 4 commits into from
May 7, 2021
Merged

Add a widget api #171

merged 4 commits into from
May 7, 2021

Conversation

mfussenegger
Copy link
Owner

@mfussenegger mfussenegger commented May 5, 2021

This allows users to show widgets (frames, scopes, evaluated expressions) in a
sidebar or in floating windows.

This is based on #165 but the
existing variables functionality is left untouched.
Once the widget functionality has feature parity the ui.variables functionality
could be deprecated and later removed.

recording.mp4

Comment on lines +698 to +708
- sidebar({widget})
Creates a view for a sidebar. You must call `open` on the result to open the window.

- cursor_float({widget})
Opens the contents of the widget in a floating window anchored at the cursor.

- centered_float({widget}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be a low hanging fruit to add a winopts argument here - similar to how repl.open works?

@mfussenegger mfussenegger force-pushed the widget-api branch 2 times, most recently from 3e4bae0 to 63ecbfc Compare May 5, 2021 20:43
This allows users to show widgets (frames, scopes, evaluated expressions) in a
sidebar or in floating windows.
`node.__parent` can point past the "root".

Example case is when the scopes are viewed and expanded, and then a
`hover()` is called on a variable..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant