Add hlint #106
Merged
Add hlint #106
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua/lint/linters/hlint.lua
Outdated
| ["start"] = { line = item.startLine, character = item.startColumn }, | ||
| ["end"] = { line = item.endLine, character = item.endColumn }, | ||
| }, | ||
| severity = vim.lsp.protocol.DiagnosticSeverity.Error, |
There was a problem hiding this comment.
The output has a severity property - that could be used here to avoid reporting everything as errors.
hlint --json Foo.hs | jq
[
{
"module": [
"Main"
],
"decl": [
"foo"
],
"severity": "Warning",
"hint": "Use concatMap",
"file": "Foo.hs",
"startLine": 110,
"startColumn": 10,
"endLine": 110,
"endColumn": 28,
"from": "concat (map op xs)",
"to": "concatMap op xs",
"note": [],
There was a problem hiding this comment.
Indeed, missed this. According this there's 3 levels, but they're all in Title case (also evident in your example). Is it gonna be ok?
This reverts commit 96d1f20.
|
Let me update the failing test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.S. It appears my formatter has gone and prettier-ified the README. If you're against this I'd be happy to undo this.