Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change! Now DbMigrationGenerator::generate() method returns a list of strings. #291

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

mfvanek
Copy link
Owner

@mfvanek mfvanek commented Sep 30, 2023

Closes #290

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (717c5c8) 100.00% compared to head (d00fa51) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #291   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       827       826    -1     
===========================================
  Files            122       122           
  Lines           1802      1798    -4     
  Branches         130       129    -1     
===========================================
- Hits            1802      1798    -4     
Files Coverage Δ
...nek/pg/generator/AbstractDbMigrationGenerator.java 100.00% <100.00%> (ø)
...erator/ColumnWithSerialTypeMigrationGenerator.java 100.00% <100.00%> (ø)
...nek/pg/generator/ForeignKeyMigrationGenerator.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfvanek mfvanek merged commit 06704fc into master Oct 1, 2023
9 checks passed
@mfvanek mfvanek deleted the bugfix/generate-migrations-separately branch October 1, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to change migrations generator API - return List<String> instead of joint String
1 participant