Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of AdditionalValidators and code duplication. Contains breaking changes! #404

Merged
merged 4 commits into from
May 26, 2024

Conversation

mfvanek
Copy link
Owner

@mfvanek mfvanek commented May 26, 2024

@mfvanek mfvanek added this to the 0.12.0 milestone May 26, 2024
Copy link

sonarcloud bot commented May 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f60e9b0) to head (ed4562b).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #404   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       949       945    -4     
===========================================
  Files            146       145    -1     
  Lines           2042      2037    -5     
  Branches         134       134           
===========================================
- Hits            2042      2037    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfvanek mfvanek merged commit a2d1701 into master May 26, 2024
7 of 8 checks passed
@mfvanek mfvanek deleted the bugfix/bloat-queries branch May 26, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of AdditionalValidators and code duplication Retest bloat queries on large tables
1 participant