-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming and functionality of below function #5
Comments
@wezzle, thank you for your PR, and for using styled-breakpoints. To better understand how breakpoints work in styled-breakpoints, refer to the following sources. |
@mg901 Thank you for your reply. Ok, I get where it comes from now. Bootstrap 4 however uses different naming where it is more logical what functionality is used. They use
Which is wrong, as in his case it gives a max-width of When naming the function I would like to hear your thoughts on this |
@wezzle Sorry for the long answer )). Thank you so much for using styled-breakpoints. I think that you are right and it is worth renaming the function |
I'm so expected to this updating. Please fix it 😄 |
@sorosora Done! |
The below function now uses the next breakpoint instead of the current.
Is this intended? Because when writing below('tablet') I would thing to receive a media query that specifies < 768px. Now it uses the next breakpoint and gives you < 992px (desktop)
See pull request: #6
The text was updated successfully, but these errors were encountered: