Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not use below function on highest breakpoint #4

Closed
Ontopic opened this issue Nov 14, 2018 · 6 comments
Closed

Can not use below function on highest breakpoint #4

Ontopic opened this issue Nov 14, 2018 · 6 comments

Comments

@Ontopic
Copy link

Ontopic commented Nov 14, 2018

This should be possible, right?

@mg901
Copy link
Owner

mg901 commented Nov 15, 2018

@Ontopic Hello! Sorry for the long answer )) You cannot use the function below for the highest breakpoint, since it takes the last maximum breakpoint value. The highest breakpoint simply does not have it.
styled-breakpoints

@Ontopic
Copy link
Author

Ontopic commented Nov 15, 2018

Thanks for your detailed response (and a lovely package).

Maybe a more detailed error message (perhaps even linking to this issue) would be nice.

@mg901 mg901 closed this as completed Nov 15, 2018
@Ontopic
Copy link
Author

Ontopic commented Nov 16, 2018

We'll be submitting a pull request, it seems there is a small mixup.

@mg901 mg901 reopened this Nov 16, 2018
@mg901
Copy link
Owner

mg901 commented Nov 16, 2018

@Ontopic, Deal!

@mg901
Copy link
Owner

mg901 commented Jan 20, 2019

@Ontopic At your request, it made the message more obvious.

@mg901 mg901 closed this as completed Apr 15, 2019
@mg901 mg901 reopened this Jul 15, 2019
mg901 pushed a commit that referenced this issue Jul 15, 2019
## [6.6.4](v6.6.3...v6.6.4) (2019-07-15)

### Bug Fixes

* add link to issue[#4](#4) ([326fc91](326fc91))
* fix error message for "above", "between" ([df1965b](df1965b))
@mg901 mg901 closed this as completed Nov 10, 2019
@sschottler
Copy link

This affects the between method too. I found it a bit unintuitive that the 2nd parameter was inclusive. The api seems to differ from other similar packages with a between concept:

https://github.com/morajabi/styled-media-query#between

https://github.com/jameslnewell/styled-components-breakpoint#breakpointgte-lt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants