Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not set mermaid js url via sphinx #47

Closed
nojas15 opened this issue Jun 25, 2020 · 3 comments
Closed

Can not set mermaid js url via sphinx #47

nojas15 opened this issue Jun 25, 2020 · 3 comments

Comments

@nojas15
Copy link

nojas15 commented Jun 25, 2020

If I want to use a locally installed mermaid version, it is not possible:

sphinxcontrib-mermaid/sphinxcontrib/mermaid.py

Line 221 in 8679e1e

self._mermaid_js_url = 'https://unpkg.com/mermaid@{}/dist/mermaid.min.js'.format(version)

Please make self._mermaid_js_url changeable via sphinx.
@mgaitan
Copy link
Owner

mgaitan commented Jun 25, 2020

hi @nojas15 . I agree, this should be configurable. Are you interested in sending a pull request?

@strefli3
Copy link

I would like this feature as well, and I'd me happy to contribute that is an option.

sleepytraveler added a commit to sleepytraveler/sphinxcontrib-mermaid that referenced this issue Nov 7, 2020
@sleepytraveler
Add path to local mermaid.js file.
a6bf329 
Fixes mgaitan#47
@sleepytraveler sleepytraveler mentioned this issue Nov 7, 2020
Closed
sleepytraveler added a commit to sleepytraveler/sphinxcontrib-mermaid that referenced this issue Dec 10, 2020
@sleepytraveler
Add path to local mermaid.js file.
e832731 
Fixes mgaitan#47
@mgaitan
Copy link
Owner

mgaitan commented Feb 1, 2021

this is currently fixed .

@mgaitan mgaitan closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add path to local mermaid.js file. sleepytraveler/sphinxcontrib-mermaid
3 participants
@strefli3 @mgaitan @nojas15