Adapt to upcoming Sphinx==4.0 release #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
|
I'm hitting this as well, any chance this can be merged? |
copybara-service bot
pushed a commit
to google/pigweed
that referenced
this pull request
May 10, 2021
Version >=4.0.0 of Sphinx removes some APIs, one of which is used by sphinxcontrib-mermaid. Error: Running Sphinx v4.0.0 Extension error: Could not import extension sphinxcontrib.mermaid (exception: cannot import name 'ENOENT' from 'sphinx.util.osutil' Failed roll: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/44223 This workaround can be removed after mgaitan/sphinxcontrib-mermaid#71 is merged. No-Docs-Update-Reason: Sphinx 4.0 workaround. Change-Id: I63e192428dda4efa228dea892ef857c782ec5674 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/44320 Commit-Queue: Anthony DiGirolamo <tonymd@google.com> Pigweed-Auto-Submit: Anthony DiGirolamo <tonymd@google.com> Reviewed-by: Rob Mohr <mohrr@google.com>
|
Hey, I have the same issue too! @mgaitan Can you help us, please?! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #72.
sphinx.util.osutil.ENOENTis deprecated since Sphinx==2.0 and is removed in the upcoming 4.0 release, breaking compatibility. Since Python 2 is not supported by Sphinx anymore anyway,FileNotFoundErroris used instead. Other than that, I have adjusted tests to work with 4.0.@mgaitan if you approve the PR, can you publish the next release early enough so we are prepared for the upcoming 4.0 release on 8th May?
Signed-off-by: oleg.hoefling oleg.hoefling@gmail.com