Fix #68 by setting mermaid init JS priority #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the js script is local, the initialization code is inserted before the actual `mermaid.(min.)js` include which makes the init script error with `mermaid is undefined`. According to: https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_js_file The default prioirty for `app.add_js_file` is 500, while the default priority of `html_js_files` is 800. A different solution would be to pass the path to the local mermaid.js to this plugin and have it insert it at the right time but I am not familiar enough with this code base to make that change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the js script is local, the initialization code is inserted before the actual
mermaid.(min.)jsinclude which makes the init script error withmermaid is undefined.According to: https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_js_file
The default prioirty for
app.add_js_fileis 500, while the default priority ofhtml_js_filesis 800.A different solution would be to pass the path to the local mermaid.js to this plugin and have it insert it at the right time but I am not familiar enough with this code base to make that change