Gnome-Shell 43 compatibility update. #26
Conversation
On first build it won't be present.
We're going to be uploading this to extensions.gnome.org, which means it needs to have a different UUID from the upstream version. Append a -next to ensure uniqueness. Also update the description to clarify provenance.
Add a syncer action and associated workflow that periodically rebases this fork with upstream and force pushes the result to our master branch.
Add an uploader action and associated workflow to package up and upload the extension to extensions.gnome.org when a push to master touches the extension code. This works in tandem with the syncer action to continuously update the extension on extensions.gnome.org with upstream's master branch.
When the rebase fails the repo ends up in a mangled state. For example, .github/sync-failed-template.md might not even be present in the source directory after the failed rebase, which causes the "create-an-issue" action to fail. Fix this by aborting the rebase on failure so that the source directory gets back to a sane state. Fixes: https://github.com/mgalgs/gnome-shell-system-monitor-applet/runs/4106665884 Error: File .github/sync-failed-template.md could not be found in your project's workspace. You may need the actions/checkout action to clone the repository first.
We don't really need to sync every hour. Bump it to every 6 hours to save the environment for posterity. Fixes #24
Copy commit from paradoxxxzero/gnome-shell-system-monitor-applet
I had the same thought. Made a comment on the PR upstream. |
|
@Fire-man-x thanks for the fix. However, I want to see what upstream does with it before taking this change. If upstream remains unresponsive we can take this here, but I want to give them a few days at least. |
|
The fix works just fine. @mgalgs I agree that, normally, waiting for upstream is a right thing, but this particular upstream is known for the lack of responsiveness 🤷 |
|
I'll merge it Friday if upstream still hasn't responded. |
|
As a matter of courtesy, you probably should have copied the commits in a way that kept their author as @glerroo so he keeps the credit, e.g. |
|
@ZimbiX Ok, thanks for advice, next time I will know |
|
Nice work! Thanks! |
|
Keep in mind this little change in travis setup to avoid the same CI block of upstream. |
|
All right, I've integrated the patches from the upstream PR (original authorship intact) and a new build has been submitted to extensions.gnome.org. Updates should be landing as soon as the Gnome team reviews the new submission (they're usually pretty quick, < 24 hours). Thanks, @Fire-man-x, for the PR and everyone else for your input 🙏 |
|
Fixes #25 |
Copy commit from paradoxxxzero/gnome-shell-system-monitor-applet
Close issue: paradoxxxzero#749 and paradoxxxzero#751.