Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@inherits compatibility issue - fix? #24

Closed
mgalloy opened this issue Oct 22, 2012 · 3 comments
Closed

@inherits compatibility issue - fix? #24

mgalloy opened this issue Oct 22, 2012 · 3 comments

Comments

@mgalloy
Copy link
Owner

mgalloy commented Oct 22, 2012

I used the following to find and remove all lines with @inherits in them. This appears to be a safe option to deal with the resultant warnings. My understanding is that inheritance is automatically found from the IDL code now.

# in every *.pro file find lines with @inherits and delete them
find . -type f -name '*.pro' -exec sed -i '/@inherits/ D' {} \;
@ghost ghost assigned mgalloy Oct 22, 2012
@mgalloy mgalloy closed this as completed Oct 22, 2012
@mgalloy
Copy link
Owner Author

mgalloy commented Oct 22, 2012

Yes, inheritance is handled automatically now as long as automatic structure definition is used to define the class instance variables. It should be able to handle multiple class definitions in a single file as well.

The find command is handy. But be careful of the case where the @inherits is spread across multiple lines. For example, some people comment in this style:

; @inherits
;   SomeClass1, SomeClass2

There was already a warning for @uses tag at the routine level, I added a warning at the file level in r433.

@mgalloy
Copy link
Owner Author

mgalloy commented Oct 22, 2012

Author: anonymous
Thanks for adding compatability comments ot ISSUES. I suggest that you add a comment there about @inherits (and other deprecated tags if there are any).

@mgalloy
Copy link
Owner Author

mgalloy commented Oct 22, 2012

Fixed in r448, I added an item in ISSUES for the "inherits" tag and another for the ASSISTANT and PREFORMAT keywords that are obsoleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant