Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wii port - Super Game Boy with special borders have problems with screen size #1204

Closed
SieKensou opened this issue Oct 4, 2018 · 8 comments

Comments

@SieKensou
Copy link

@SieKensou SieKensou commented Oct 4, 2018

When I load a game that uses the Super Game Boy special borders the screen is showed in the original resolution (although I have other size in options) and it only appear bigger if I set the bigger value in horizontal and vertical size, the other values doesn't do nothing and the bigger one is not good for me because a bit part of the top of the screen is cut.

I tested without the BIOS because for some reason I can't select it now in this version... When I select my BIOS folder they don't appear to be selected. What extension needs to have the GB, GBC and SGB BIOS files? (and if you can tell me the right CRC32 for the supported SGB v2 BIOS file it would be great, I'm not sure if the one I found is the right one).

@endrift

This comment has been minimized.

Copy link
Member

@endrift endrift commented Oct 4, 2018

I don't understand. Can you rephrase the issue or add some diagrams?

Also the BIOS settings are for directly setting the files, not folders.

@SieKensou

This comment has been minimized.

Copy link
Author

@SieKensou SieKensou commented Oct 4, 2018

Okay, sorry for the mess triying to explain the problem.
For example, for "normal" Game Boy games, Game Boy Color games and Game Boy Advance Games I have the horizontal and vertical scale set to 0.9 and the games appear in big size on the screen. If I load a game that uses a Super Game Boy border, with that same settings, the game appear with very small size on the screen.

About the BIOS, yeah, sorry again, I mean that the Super Game Boy BIOS doesn't appear to select (I just see the GB and GBC BIOS when I try to select the SGB v2 BIOS. Does it check for a specific CRC32 file or something? Does the emulator support the Super Game Boy v2 BIOS?

@endrift

This comment has been minimized.

Copy link
Member

@endrift endrift commented Oct 4, 2018

Yeah, it checks for CRC32s. I don't believe the CRC32 for the SGB2 boot ROM is present at the moment.

@endrift

This comment has been minimized.

Copy link
Member

@endrift endrift commented Oct 4, 2018

Anyway if you want the game to take up the same amount of space as it would without the borders you can just turn off the borders in settings.

@SieKensou

This comment has been minimized.

Copy link
Author

@SieKensou SieKensou commented Oct 4, 2018

Okay, yes, but shouldn't the game with border takes the same space on the screen (including borders) that other game without border? No matter what value I put in options when a game uses borders, only if I set 1.0 in horizontal and vertical scale makes a game with border in full screen, all the other values makes the game looks like if it was set at the minimum scale... I wouldn't be a problem to set the value 1.0 to all the games, but when I set that value, for some reason, the first line of the emulatur (where it says GAME PAUSED and where it shows the clock appears cut because part of that line goes out of the screen). And anyway, if it's possible I would prefer not to use full screen for the GB/GBC games. The best option would be that the games with borders takes the same screen size as the non-border games without taking into account the border because this way all games would run at the same size.

Would be the SGB2 added anytime soon?
Thanks.

@endrift

This comment has been minimized.

Copy link
Member

@endrift endrift commented Oct 4, 2018

That's not supported with how SGB borders are implemented right now, but I can add it at some point in the future.

@endrift

This comment has been minimized.

Copy link
Member

@endrift endrift commented Oct 4, 2018

FWIW I've pushed SGB2 support

@endrift endrift added this to the mGBA 0.8.0 milestone Oct 4, 2018
@SieKensou

This comment has been minimized.

Copy link
Author

@SieKensou SieKensou commented Oct 5, 2018

Thank you very much, you are doing a great job with this emulator.

@endrift endrift closed this in 1928d2b Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.