Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mark next to FPS option "Native (59.7)" disappears #436

Closed
CharlesCorrin opened this issue Oct 9, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@CharlesCorrin
Copy link

commented Oct 9, 2016

1: Go to Audio/Video, then FPS target. Select Native (59.7).

2: Go to Tools and select Settings...

3: Click OK.

4: Go back to Audio/Video's FPS target. The check mark beside Native (59.7) will have disappeared.

Aside, perhaps it should read "Native (59.73)" instead to match the option on the Settings screen?

@endrift endrift added this to the 0.5.2 milestone Oct 10, 2016

@CharlesCorrin

This comment has been minimized.

Copy link
Author

commented Oct 10, 2016

I'd like to apologize for this lackluster bug report, by the way. I was too tired when I wrote it. Sorry. I'll fix it a bit now.

I was using the most recent Windows test build at the time. I'm using Windows 10 Home Edition, 64-bit.

@karasuhebi

This comment has been minimized.

Copy link

commented Jan 4, 2017

Just to give more information:

This issue occurs when you click on "OK". If you check, the checkmark will still be there while the Settings window is opened. It will also stay there if you click "Cancel" in the Settings window.

@endrift endrift modified the milestones: 0.6.0, 0.6.1 Apr 22, 2017

@endrift endrift modified the milestones: mGBA 0.6.1, mGBA 0.6.2 Sep 30, 2017

@endrift endrift modified the milestones: mGBA 0.6.2, mGBA 0.7.0 Apr 14, 2018

@CharlesCorrin

This comment has been minimized.

Copy link
Author

commented Sep 16, 2018

It's been a while, but I have more info on this.

When you select the "Native 59.7" option from the "FPS target" menu under "Audio/Video", the program writes "fpsTarget=59.727500915527344" to config.ini.

When you open the Settings window, it reads the above mentioned fpstarget setting and interprets it as 59.73. From there, when you select OK, the program writes "fpsTarget=59.73" to config.infi.

The two options thus write different results to config.ini. I don't know which would be correct in this instance. I guess the 59.73 is?

@endrift

This comment has been minimized.

Copy link
Member

commented Sep 16, 2018

The correct value is approximately 59.727500569605832763727500569605832763..., or exactly 262144/4389.

@endrift endrift closed this in 12d77b6 Sep 16, 2018

@CharlesCorrin

This comment has been minimized.

Copy link
Author

commented May 22, 2019

Hey. I found another version of this bug.

In the drop-down menu, select 60 fps. Then select native from the same menu. Close the emulator. The following will be written to the ini:
fpsTarget=59.72750056960583

It will stay this way until you go to the Settings menu and select OK. Then this will be written to the ini:
fpsTarget=59.7275

Also, for some reason you can click on the checkbox in the drop-down menu again. It will deselect all options in the fps menu if you do that.

EDIT: Oh, and of course I'm using the most recent MGBA build at the time of this post. I always stay up to date. :3

@endrift

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Both of these should be fixed now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.