ImageMagick 7 build failure

[ilovezfs]

Tested with mgba 0.5.2 since Homebrew has switched from legacy version of ImageMagick to the current stable version of ImageMagick, which is version 7.

Build failure:

[ 57%] Building C object CMakeFiles/mgba.dir/src/feature/imagemagick/imagemagick-gif-encoder.c.o
/usr/local/Homebrew/Library/Homebrew/shims/super/clang  -DBUILD_GL -DBUILD_GLES2 -DBUILD_SDL -DHAVE_CHMOD -DHAVE_LOCALE -DHAVE_LOCALTIME_R -DHAVE_SETLOCALE -DHAVE_SNPRINTF_L -DHAVE_STRDUP -DHAVE_STRNDUP -DHAVE_STRTOF_L -DHAVE_UMASK -DM_CORE_GB -DM_CORE_GBA -DUSE_CLI_DEBUGGER -DUSE_EPOXY -DUSE_FFMPEG -DUSE_GDB_STUB -DUSE_LIBZIP -DUSE_LZMA -DUSE_MAGICK -DUSE_PNG -DUSE_PTHREADS -DUSE_ZLIB -D_7ZIP_PPMD_SUPPPORT -D_DARWIN_C_SOURCE -Dmgba_EXPORTS -I/tmp/mgba-20170127-29109-166tzqx/mgba-0.5.2/src -I/usr/local/include -I/usr/local/include/editline -I/usr/local/Cellar/ffmpeg/3.2.2/include -I/usr/local/Cellar/imagemagick/7.0.4-5/include/ImageMagick-7 -I/usr/local/Cellar/libzip/1.1.2/include -I/usr/local/Cellar/libzip/1.1.2/lib/libzip/include -I/tmp/mgba-20170127-29109-166tzqx/mgba-0.5.2/third-party/lzma -I/usr/local/Cellar/libepoxy/1.3.1/include  -Wall -Wextra -Wno-missing-field-initializers -std=c99 -mmacosx-version-min=10.6 -DNDEBUG -flto -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.11 -fPIC   -o CMakeFiles/mgba.dir/src/feature/imagemagick/imagemagick-gif-encoder.c.o   -c /tmp/mgba-20170127-29109-166tzqx/mgba-0.5.2/src/feature/imagemagick/imagemagick-gif-encoder.c
In file included from /tmp/mgba-20170127-29109-166tzqx/mgba-0.5.2/src/feature/imagemagick/imagemagick-gif-encoder.c:6:
/tmp/mgba-20170127-29109-166tzqx/mgba-0.5.2/src/feature/imagemagick/imagemagick-gif-encoder.h:14:10: fatal error: 'wand/MagickWand.h' file not found
#include <wand/MagickWand.h>
         ^
1 error generated.
make[2]: *** [CMakeFiles/mgba.dir/src/feature/imagemagick/imagemagick-gif-encoder.c.o] Error 1
make[1]: *** [CMakeFiles/mgba.dir/all] Error 2
make: *** [all] Error 2

I can work around it with the following string replacement:

    inreplace "src/feature/imagemagick/imagemagick-gif-encoder.h",
      "wand/MagickWand.h", "ImageMagick-7/MagickWand/MagickWand.h"

It would be great if CMake could check which version of ImageMagick is available and use the corresponding header location since that's the only tweak needed for a successful build.

Thanks!

[endrift]

You're about a week late: 2e3daae.

[ilovezfs]

Cool. Mind tagging a new release? 😇

[endrift]

I have no plans to tag a new release just for a buildfix due to an external library changing API. The next release will be 0.6.0 in a few weeks, or--if I fix a specific fairly critical bug--0.5.3 whenever that bug gets fixed.

Otherwise, I generally expect package maintainers to handle these sorts of things on their end.

[ilovezfs]

OK. I've applied the commit inline https://github.com/Homebrew/homebrew-games/pull/782.

[endrift]

Sounds good 👍. This will be definitely fixed in whichever next release is out, so you can remove the patch then.