Implemented in-app search with Google Assistant #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderFroemmgen
approved these changes
Sep 8, 2020
| @@ -542,40 +544,54 @@ public Snackbar showSnackbarAbovePlayer(int text, int duration) { | |||
| } | |||
|
|
|||
| /** | |||
| * Handles the incoming deep link and loads the relevant fragment. | |||
| * By default, opens the "Add Podcast" feature. | |||
| * Handles the deep link incoming via App Actions and according to the query | |||
There was a problem hiding this comment.
Nitpicking: What about splitting the long sentence, e.g., like
Handles the deep link incoming via App Actions. Performs an in-app search or opens the relevant feature of the app depending on the query.
| } | ||
| switch (uri.getPath()) { | ||
| case "/search": | ||
| String query = uri.getQueryParameter("query"); |
There was a problem hiding this comment.
Did you consider to extract a method for this case?
| break; | ||
| default: |
There was a problem hiding this comment.
Why is this not needed anymore?
mgborowiec
added a commit
that referenced
this pull request
Sep 10, 2020
* Implemented in-app search with Google Assistant * Updated a comment to split long sentences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the “Get thing” built-in intent (https://developers.google.com/assistant/app/reference/built-in-intents/common/get-thing) to enable users to use the in-app search of AntennaPod directly from the Google Assistant with queries of type “Search for BBC on AntennaPod”.
It can be tested with the App Actions test tool plugin in Android Studio (https://developers.google.com/assistant/app/test-tool). App Actions are supported on Android 5 (API level 21) and higher, and can only be tested with a physical device.