Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Commit

Permalink
fix(datepicker): properly handle timezone for minDate/maxDate
Browse files Browse the repository at this point in the history
  • Loading branch information
mgcrea committed Jan 21, 2014
1 parent bf51874 commit d4a6424
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions src/datepicker/datepicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,11 @@ angular.module('mgcrea.ngStrap.datepicker', ['mgcrea.ngStrap.tooltip'])
angular.forEach(['minDate', 'maxDate'], function(key) {
// console.warn('attr.$observe(%s)', key, attr[key]);
angular.isDefined(attr[key]) && attr.$observe(key, function(newValue) {
// console.warn('attr.$observe(%s)=%o', key, newValue, !!datepicker);
// console.warn('attr.$observe(%s)=%o', key, newValue);
if(newValue === 'now' || newValue === 'today') newValue = null;
if(newValue.match(/^".+"$/)) newValue = newValue.substr(1, newValue.length - 2);
datepicker.$options[key] = +new Date(newValue);
var parsedDate = new Date(newValue);
datepicker.$options[key] = parsedDate.getTime() - parsedDate.getTimezoneOffset() * 6e4;
!isNaN(datepicker.$options[key]) && datepicker.$build();
});
});
Expand Down
4 changes: 2 additions & 2 deletions src/datepicker/test/datepicker.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,10 @@ describe('datepicker', function() {
it('should support a dynamic maxDate', function() {
var elm = compileDirective('options-maxDate');
angular.element(elm[0]).triggerHandler('focus');
expect(sandboxEl.find('.dropdown-menu tbody button[disabled]').length).toBe(7);
expect(sandboxEl.find('.dropdown-menu tbody button[disabled]').length).toBe(6);
scope.maxDate = '02/12/86';
scope.$digest();
expect(sandboxEl.find('.dropdown-menu tbody button[disabled]').length).toBe(17);
expect(sandboxEl.find('.dropdown-menu tbody button[disabled]').length).toBe(16);
});

});
Expand Down

0 comments on commit d4a6424

Please sign in to comment.