This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
fix: $typeahead Enable scrolling of typeahead on $keydown when $typeahead.$element container has max-height css set #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as max-height. Add function to update scrollTop property on $typeahead.$element when avtive entry leaves visible window of the scrollable container ($typeahead.$element).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to update scrollTop property on $typeahead.$element when avtive entry leaves visible window of the scrollable container ($typeahead.$element).
Should fix issues
I tried to add test cases but failed to validate the updated scrollTop property.
Adding test cases to validate setting scrollTop using mock objects should be more painless. I could provide that.
Regards Dirk