Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rigbits: Gimmick SetupTool bugs and enhancements #279

Open
4 tasks done
miquelcampos opened this issue Sep 19, 2023 · 7 comments
Open
4 tasks done

rigbits: Gimmick SetupTool bugs and enhancements #279

miquelcampos opened this issue Sep 19, 2023 · 7 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@miquelcampos
Copy link
Member

miquelcampos commented Sep 19, 2023

some bugs related to: NewFeature: Gimmick SetupTool has been added in rigbits #272

  • mirror blend joints in default biped is not working
  • If click mirror with a regular joint selected will break the joint structure connection
  • change the .json extension to something like .gst this will help add a drag and drop behavior in the future, by making a distinction of the file type
  • Please add some documentation on how to use the tool. In general is very straightforward, but I didn't get the use of side tagging in the creation section. I think that is inherited from the parent joint, but maybe missing something 😅
    image
    Thanks!
@miquelcampos miquelcampos added the bug Something isn't working label Sep 19, 2023
@miquelcampos miquelcampos added this to To Do in mGear 4.x via automation Sep 19, 2023
@miquelcampos miquelcampos added the enhancement New feature or request label Sep 19, 2023
@miquelcampos miquelcampos moved this from To Do to WIP in mGear 4.x Sep 19, 2023
miquelcampos added a commit that referenced this issue Sep 19, 2023
@joji2468ng
Copy link
Member

Thank you for testing the tool!

I will address all of the identified issues and create documentation.

Currently, the tool relies on joint naming rules derived from a guide node. This approach has limitations, as it requires the presence of a guide node in the scene for the process to proceed.

To improve this, I suggest incorporating the naming rule pattern within the top rig node as an extra attribute. At the same time, we can add a controller naming pattern as well. What do you think?

Thanks!

@miquelcampos
Copy link
Member Author

miquelcampos commented Sep 19, 2023

@joji2468ng since the last release we started embedding the guide description in the rigs. You will find all the information there 😉
#248
EDIT: I think we need to remove the dependency of the guide. Maybe is a guide from another rig or we have multiple guides in the scene. That can cause issues

@joji2468ng
Copy link
Member

Wow, I found all the information there. it seemed to miss the new feature!
I realized that this can cause issues in any case, okay I will fix the part as well.

I will let you know once I finish all of them!

@joji2468ng
Copy link
Member

joji2468ng commented Sep 22, 2023

Hi @miquelcampos I've just submitted a pull request with all bugs fixed, and new features. #284
I've changed the UI layout and added flip joint buttons as a sub button.
Thanks,

image

@miquelcampos miquelcampos moved this from WIP to Pending Review in mGear 4.x Sep 27, 2023
@joji2468ng
Copy link
Member

joji2468ng commented Sep 29, 2023

Hi @miquelcampos , Thank you for merging the pull request!
It seems like the tool menu has been commented out since it was reverted back.

Could you take a look at it when you have time?

Thanks,

image

@miquelcampos
Copy link
Member Author

@joji2468ng Yes, I know. However I have found some issues while testing it.
The issue is when you add a support joint to a blend joint, and mirror. The support joint will not change the side in the name.
I will record a video ASAP

@joji2468ng
Copy link
Member

I just found out the bug on my end, will fix it ASAP.

@joji2468ng joji2468ng self-assigned this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
mGear 4.x
Pending Review
Development

No branches or pull requests

2 participants