Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBFManager: fix mirroring and add manual entry feature #155

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

miabrahams
Copy link
Contributor

Fix some pain points encountered using the RBF manager. Typing in the exact numerical values can make it easier to get smooth transitions between RBFs.

Two components.

1. Remove a bug in rbf_manager where poses would be zeroed out in the middle of
mirroring.

2. Simplify the control mirroring code in anim_utils to make it more robust.
Sometimes you just want to type in the values for your RBF. This adds an extra
button to commit edit   s back to the node.
@miquelcampos miquelcampos self-assigned this Oct 10, 2022
@miquelcampos miquelcampos added the enhancement New feature or request label Oct 10, 2022
@miquelcampos miquelcampos added this to In progress in mGear 4.0 via automation Oct 10, 2022
@miquelcampos
Copy link
Member

Thanks @miabrahams I will check the PR and merge ASAP

@miquelcampos miquelcampos removed this from In progress in mGear 4.0 Jan 12, 2023
@miquelcampos miquelcampos added this to To Do in mGear 4.x via automation Jan 12, 2023
@miquelcampos miquelcampos merged commit f24d484 into mgear-dev:master Jan 12, 2023
mGear 4.x automation moved this from To Do to 4.1.x Jan 12, 2023
@miquelcampos
Copy link
Member

HI, @miabrahams sorry for the long wait, finally I have merged your PR. Thank you very much for your contribution! 😄

@miabrahams
Copy link
Contributor Author

Happy to help Miquel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 4.1.x
Development

Successfully merging this pull request may close these issues.

None yet

2 participants