-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to overtake maintainership #19
Comments
It appears issues are disabled on your fork, which would certainly be far from ideal as a new maintained location for the extension. |
We will move this to the public WMF git repository. By this issues can be tracked using WMF Phabricator (https://phabricator.wikimedia.org/), contributions and code review will be handled within the WMF Gerrit insfrastructure (https://www.mediawiki.org/wiki/Gerrit) |
This extension is now [1] maintained on WMF gerrit. Please file any bug report at https://phabricator.wikimedia.org/tag/mediawiki-extensions-drawioeditor/ |
I left a comment in #10, that I opened a change on gerrit (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DrawioEditor/+/652185), has anyone noticed that change? Is there anything I should do, to get that change reviewed and merged? |
I have seen it, thank you! I will review/merge it as soon as possible. |
thanks and no rush, I only couldn't see any progress... |
I have amended you change a little bit. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DrawioEditor/+/652185/1..8 It's mainly two things:
I have also added the If you have no objections to the changes I did to your code, I'd merge it within the next few days. |
thanks a lot, you have more detailed experiences with that code, so I'm completely fine with your changes... I'm not sure, what is the exact difference between |
hello @osnard, is there any problem with merging the change? |
ping... |
Hi! Sorry, I have asked a colleague to take care of this. Will check and give feedback asap. |
Okay, so it looks like your proposed changes have been merged in another commit that also had some additional changes
Can you please check if your changes are applied properly (I believe they should be) and maybe abandon your original change? |
Thanks, from code view in gerrit, all changes are include in 659221, I'll test the commit in a test installation and give feedback here... I abandoned my original change... |
Works like expected, thanks to anyone making this work... |
Hello!
My colleagues and me have already applied some changes in our fork (https://github.com/hallowelt/mediawiki-extensions-DrawioEditor). We are planning to add additional functionality. If you don't mind, we'd officially overtake the maintainership and also change the download link on https://www.mediawiki.org/wiki/Extension:DrawioEditor
Best regards!
The text was updated successfully, but these errors were encountered: