Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services giving too many options on naming... #53

Closed
phillip-haydon opened this issue May 24, 2014 · 5 comments
Closed

services giving too many options on naming... #53

phillip-haydon opened this issue May 24, 2014 · 5 comments

Comments

@phillip-haydon
Copy link

Why are services given the option of camelCase and PascalCase... The moment I read this it just sounds like "do what ever you want who cares about having any style guide"...

To be honest I don't know if this is mentioned anywhere else because I almost feel like this guide isn't worth following now... (poor excuse to not read the rest, I know)

Also can we stop with the confusing/bad terminology of 'camelCase (lower or upper)' and 'lowerCamelCase', I don't know where the industry came up with the idea that camelCase should have two variants but it needs to stop.

@mgechev
Copy link
Owner

mgechev commented May 24, 2014

I agree with your note. Actually, I use different conventions for the different types of services.

My constructor functions, encapsulated with services, are UpperCamelCase (or call it PascalCase, however), all other services use lowerCamelCase.

Since the purpose of the style guide is to be community driven, If you agree with this convention I can update the style guide following this practice.

@slacktracer
Copy link

Your reasoning, @mgechev, is the same behind functions meant to be used with the new keyword being Uppercased?

@mgechev
Copy link
Owner

mgechev commented May 24, 2014

Yes, exactly.

@phillip-haydon
Copy link
Author

Thanks for updating that 👍

Sorry if I came across angry, was frustrated at the time :)

@mgechev
Copy link
Owner

mgechev commented May 31, 2014

That's fine, feel free to open issues for another things, which are inappropriate according to your opinion :-).

In a few weeks I plan to review the style guide from its beginning and fix its weak parts (including testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants