Skip to content

Commit

Permalink
feat(use-view-encapsulation): simplify warning message
Browse files Browse the repository at this point in the history
  • Loading branch information
Gregor Woiwode committed May 3, 2017
1 parent ee6afbd commit 88e3cd4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion .vscode/settings.json
@@ -1,3 +1,5 @@
{
"typescript.tsdk": "./node_modules/typescript/lib"
"typescript.tsdk": "./node_modules/typescript/lib",
"angulardoc.repoId": "51f64839-b313-47fa-8d89-9317081ebe22",
"angulardoc.lastSync": 0
}
2 changes: 1 addition & 1 deletion src/useViewEncapsulationRule.ts
Expand Up @@ -17,7 +17,7 @@ export class Rule extends Lint.Rules.AbstractRule {
typescriptOnly: true
};

static FAILURE = 'Using "ViewEncapsulation.None" may cause conflicts between css rules having the same selector';
static FAILURE = 'Using "ViewEncapsulation.None" will make your styles global which may have unintended effect';

apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
const walker = new ViewEncapsulationWalker(sourceFile, this.getOptions());
Expand Down
2 changes: 1 addition & 1 deletion test/useViewEncapsulationRule.spec.ts
Expand Up @@ -14,7 +14,7 @@ describe('use-view-encapsulation', () => {

assertAnnotated({
ruleName: 'use-view-encapsulation',
message: 'Using "ViewEncapsulation.None" may cause conflicts between css rules having the same selector',
message: 'Using "ViewEncapsulation.None" will make your styles global which may have unintended effect',
source
});
});
Expand Down

0 comments on commit 88e3cd4

Please sign in to comment.