Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): use valid aria rules #746

Merged
merged 2 commits into from Feb 12, 2019
Merged

feat(rule): use valid aria rules #746

merged 2 commits into from Feb 12, 2019

Conversation

mohammedzamakhan
Copy link
Contributor

No description provided.

mgechev
mgechev approved these changes Feb 9, 2019
View reviewed changes
Copy link
Owner

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment. I like the string distance suggestions!

wKoza
wKoza requested changes Feb 10, 2019
View reviewed changes
test/templateAccessibilityValidAriaRule.spec.ts Outdated Show resolved Hide resolved
src/util/getSuggestion.ts Show resolved Hide resolved
mgechev
mgechev reviewed Feb 11, 2019
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@mgechev mgechev merged commit 762f67f into mgechev:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

@wKoza wKoza wKoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohammedzamakhan @mgechev @wKoza