Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: walkers/visitors being exported #793

Merged
merged 2 commits into from
Mar 23, 2019
Merged

refactor: walkers/visitors being exported #793

merged 2 commits into from
Mar 23, 2019

Conversation

rafaelss95
Copy link
Collaborator

@rafaelss95 rafaelss95 commented Mar 19, 2019 •
edited

In addition to removing the export from visitors/walkers that contained it, it renames them to a generic name to avoid confusion (ex: for templateNoAutofocus rule we are naming its visitor as TemplateConditionalComplexityVisitor:

codelyzer/src/templateNoAutofocusRule.ts

Line 29 in 799382f

class TemplateConditionalComplexityVisitor extends BasicTemplateAstVisitor {
)... and to keep them consistent.

@rafaelss95
Copy link
Collaborator Author

Friendly bump @mgechev :)

@mgechev mgechev merged commit c07ac5e into mgechev:master Mar 23, 2019
@rafaelss95 rafaelss95 deleted the refactor/remove-walker-visitor-exports branch March 28, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

@wKoza wKoza Awaiting requested review from wKoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafaelss95 @mgechev