Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive violates the Rule of Silence #165

Closed
markelog opened this issue Jul 1, 2019 · 2 comments · Fixed by #198
Closed

Revive violates the Rule of Silence #165

markelog opened this issue Jul 1, 2019 · 2 comments · Fixed by #198

Comments

@markelog
Copy link
Contributor

markelog commented Jul 1, 2019

When revive finds no errors it prints:

0 problems (0 errors) (0 warnings)

This violates the Rule of Silence:

The rule of silence, also referred to as the silence is golden rule, is an important part of the Unix philosophy that states that when a program has nothing surprising, interesting or useful to say, it should say nothing. It means that well-behaved programs should treat their users' attention and concentration as being valuable and thus perform their tasks as unobtrusively as possible. That is, silence in itself is a virtue. (http://www.linfo.org/rule_of_silence.html)

What would you say to a PR that made revive silent by default?
@mgechev
Copy link
Owner

mgechev commented Jul 1, 2019

@markelog this seems valid for the friendly & the stylish formatters. Would you fix both?

@markelog
Copy link
Contributor Author

markelog commented Jul 1, 2019

Can do :)

markelog added a commit to markelog/revive that referenced this issue Jul 29, 2019
@markelog
Adhere to "Rule of Silence"
3c44ec0 
Makes stylish formatter to respect "Rule of Silence"
See http://www.linfo.org/rule_of_silence.html

Fixes mgechev#165
markelog added a commit to markelog/revive that referenced this issue Jul 29, 2019
@markelog
fix: adhere to "Rule of Silence"
3a17e34 
Makes stylish formatter to respect "Rule of Silence"
See http://www.linfo.org/rule_of_silence.html

Fixes mgechev#165
@markelog markelog mentioned this issue Jul 29, 2019
Merged
markelog added a commit to markelog/revive that referenced this issue Jul 29, 2019
@markelog
fix: adhere to "Rule of Silence"
9387627 
Makes stylish formatter respect "Rule of Silence"
See http://www.linfo.org/rule_of_silence.html

Fixes mgechev#165
mgechev pushed a commit that referenced this issue Jul 29, 2019
@markelog @mgechev
fix: adhere to "Rule of Silence" (#198)
03c3312 
Makes stylish formatter respect "Rule of Silence"
See http://www.linfo.org/rule_of_silence.html

Fixes #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adhere to "Rule of Silence" markelog/revive
2 participants
@mgechev @markelog