Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor atomic rule code to make gofmt function available to other rules #79

Closed
chavacava opened this issue Oct 3, 2018 · 1 comment
Closed

Refactor atomic rule code to make gofmt function available to other rules #79

chavacava opened this issue Oct 3, 2018 · 1 comment

Comments

@chavacava
Copy link
Collaborator

Rule atomic has a method gofmt (attached to an internal struct).
It could be interesting to make this method accessible to other rules (eg constant-logical-expr)

I propose to move the method into rule/utils.go.
@mgechev
Copy link
Owner

mgechev commented Oct 3, 2018

Sounds good to me.

@chavacava chavacava mentioned this issue Oct 3, 2018
Merged
mgechev pushed a commit that referenced this issue Oct 3, 2018
@chavacava @mgechev
Refactors atomic rule code to move gofmt function to utils.go (is…
da63d0a 
…sue #79)  (#80)

* Refactoring on atomic rule:
-Main modification: move func gofmt to utils.go

* Refactoring on constant-logical-expr rule
Simplifies equality check of subexpressions by using gofmt function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgechev @chavacava