Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support private _UPPER_CASED_CONST with var-naming and upperCaseConst=true #865

Closed
fregin opened this issue Aug 10, 2023 · 0 comments · Fixed by #866
Closed

support private _UPPER_CASED_CONST with var-naming and upperCaseConst=true #865

fregin opened this issue Aug 10, 2023 · 0 comments · Fixed by #866

Comments

@fregin
Copy link
Contributor

fregin commented Aug 10, 2023 •
edited

I see new feature added last week #851 with allowing to use uppercase constants.

I think there should be also a private uppercase constant support for this feature.

const _SOME_PRIVATE_CONST = "hello, world"
@fregin fregin changed the title support private _UPPER_CASED_CONST with var-naming and upperCaseConst=true support private _UPPER_CASED_CONST with var-naming and upperCaseConst=true Aug 10, 2023
@fregin fregin mentioned this issue Aug 10, 2023
Merged
chavacava pushed a commit that referenced this issue Aug 12, 2023
@fregin
(var-naming) support private uppercase constants #865 (#866)
72f9108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(var-naming) support private uppercase constants #865 fregin/revive
1 participant
@fregin