Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 534 #536

Merged
merged 2 commits into from Jun 29, 2021
Merged

fix 534 #536

merged 2 commits into from Jun 29, 2021

Conversation

chavacava
Copy link
Collaborator

Closes #534

@chavacava chavacava requested a review from mgechev June 29, 2021 04:30
@mgechev
Copy link
Owner

mgechev commented Jun 29, 2021

There seems to be a linting error. Aside from that LGTM.

@chavacava chavacava merged commit cfac8b0 into master Jun 29, 2021
@chavacava chavacava deleted the fix-534 branch June 29, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import-shadowing shouldn't check current package name
2 participants
@chavacava @mgechev