Comment spacing rule #761
Merged
Comment spacing rule #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgechev
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Looks great! Could you add it to the README? @chavacava for a final review.
|
Hi @qascade, thanks for the PR |
chavacava
requested changes
Oct 21, 2022
chavacava
approved these changes
Oct 29, 2022
|
Thanks @qascade ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close issue #735.
Did you add tests?
Yes, tests were added
Does your code follow the coding style of the rest of the repository?
Yes, the code was written while keeping the coding style of the repo in mind. But, if you find any decrepancy, please feel free to request a change in the code review.
Does the Travis build passes?
Yes, the build is passing along with all the tests.