Allows inversing the semantics of string-format rule configurations
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgechev
reviewed
Oct 24, 2022
rule/string-format.go
Outdated
| failure = r.errorMessage | ||
| } else { | ||
| failure = fmt.Sprintf("string literal doesn't match user defined regex /%s/", r.regexp.String()) | ||
| switch r.negated { |
There was a problem hiding this comment.
Maybe we can reduce nesting if we use if/else rather than switch:
if r.negated {
// ...
}
// else here
mgechev
reviewed
Oct 24, 2022
rule/string-format.go
Outdated
| failure = fmt.Sprintf("string literal doesn't match user defined regex /%s/", r.regexp.String()) | ||
| switch r.negated { | ||
| case false: | ||
| // Fail if the string doesn't match the user's regex |
There was a problem hiding this comment.
Suggested change
| // Fail if the string doesn't match the user's regex | |
| // Fail if the string does NOT match the user's regex |
mgechev
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a syntactic mean to negate the regular expressions in the configuration to pass from a "accept if match" to "fail if match" mode.
Now, using a
!the configuration meaning is invertedwith "/^[A-Z].$/" the rule will accept strings starting with capital letters
with "!/^[A-Z].$/" the rule will a fail on strings starting with capital letters
Closes #762