refactor: Reduce package-comments output scope #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the amount of lines reported by package-comments by only reporting the `package XXXXXXX' line, instead of the whole file.
|
Hi @heyvito, thanks for filling the issue and providing a fix. |
|
Hey @chavacava! This is more something I felt was inconsistent, but in the end I think it is a matter of opinion. I noticed this cause I'm working on a tool that leverages Revive for reporting issues, and was quite surprised when it reported the issue spanning the whole file instead of just a specific portion of it. So I'll completely understand in case you conclude this is not worth merging, or if you think the current behaviour is appropriate. Thanks for taking some time to review this! <3 |
|
Thanks @heyvito |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of lines reported by package-comments by only reporting the
package xyzline, instead of the whole file.Closes #790