resolve #867: remove k[A-Z][A-Za-z\d]*$ sub-rule from var-naming
#871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsirbe
force-pushed
the
fix/867
branch
3 times, most recently
from
0000867
to
0000867
Compare
|
Hi @martinsirbe, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the removal of
k[A-Z][A-Za-z\d]*$sub-rule fromvar-naming, as it doesn't clearly justify the reason for the check and fails to properly tackle any potential issues with Hungarian notation.The emphasis is on ensuring clarity, reducing confusion, and enhancing the overall user experience for revive users.
The sub-rule originates from golang/lint and has in the past led to false positives and confusion, see golang/lint#258.
Closes #867