feat: capitalise var naming to IDs #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @VincentBaron, thanks for the PR! |
denisvmedia
reviewed
Jan 15, 2024
VincentBaron
force-pushed
the
feat-var-naming-capitalise-ids
branch
from
17971a6
to
17f998d
Compare
|
I added a test for this case :) |
|
@denisvmedia do you know when you are planning the next tag? As I am using revive via golangci-lint I will need to do a PR to them to update to your latest version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var-namingdoes not check that ID is capitalised when it is plural such as IDs. For example if I haveuIds := []string{}it will allow this var name where really it should return varuIds should be uIDs.Closes #947