Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds rule max-control-nesting #967

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Conversation

chavacava
Copy link
Collaborator

This PR adds rule max-control-nesting, the GO implementation of https://sonarsource.atlassian.net/browse/RSPEC-134

@denisvmedia
Copy link
Collaborator

Thanks for the new rule @chavacava.

What about select/case - should we (do we?) support it as well?

Another thing: can we have test cases for the code placed in closures?

Copy link
Collaborator

@denisvmedia denisvmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Feel free to merge :)

@chavacava chavacava merged commit 3a62091 into master Jan 28, 2024
4 checks passed
@denisvmedia denisvmedia deleted the feature/max-control-nesting branch January 28, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants